Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/cragw/dock rework #7369

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Wip/cragw/dock rework #7369

merged 2 commits into from
Jun 21, 2024

Conversation

CragW
Copy link
Collaborator

@CragW CragW commented Jun 19, 2024

Type of pull request:

@CragW CragW requested review from superm1 and hughsie June 19, 2024 15:57
@CragW CragW mentioned this pull request Jun 19, 2024
Closed
4 tasks
superm1
superm1 reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@superm1 superm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. Presumably you've tested this on Salomon and Atomic already too; right?

@CragW
Copy link
Collaborator Author

CragW commented Jun 20, 2024

A few minor nits. Presumably you've tested this on Salomon and Atomic already too; right?

I've tested this PR on my WD19TB and HD22Q, no blocking issues. (tho some error prints but unrelated to this change)

The mentioned error prints as below, may need another PR to fix.

06:02:57.227 FuEngine             no GUIDs for device AUX USBC4/DDI TC4/PHY E [d762543f8c20f636e6fff031a000078d3e10c600]
06:02:57.231 FuUdevDevice         (null) [523103f1df5126ab63bfb5cccc99aac18ae89de4] forgot to call fu_udev_device_add_flag() with OPEN_READ and/or OPEN_WRITE

@CragW
Copy link
Collaborator Author

CragW commented Jun 20, 2024

tore down more instance IDs into device category's DellDockComponent.

superm1
superm1 previously approved these changes Jun 20, 2024
View reviewed changes
@CragW
Copy link
Collaborator Author

CragW commented Jun 21, 2024

caught mst issue when testing with WD22TB4, fixed in 6f08c3d

@CragW CragW merged commit 98be21b into main Jun 21, 2024
21 checks passed
@CragW CragW deleted the wip/cragw/dock_rework branch June 21, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superm1 superm1 superm1 approved these changes

@hughsie hughsie Awaiting requested review from hughsie

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CragW @superm1