Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing pct-encoding in values for reserved {+} or fragment {#} expansion must NOT be re-encoded #17

Open
JohnBrinkman opened this issue Jun 15, 2016 · 3 comments

Comments

@JohnBrinkman
Copy link

Expanding:
{"uri": "http://foo/bar?message=hello%20world"}
with the template:
{+uri}
must result in:
"http://foo/bar?message=hello%20world"

Not:

"http://foo/bar?message=hello%2520world"

From: https://tools.ietf.org/html/rfc6570#section-3.2.1
"Note that the percent character ("%") is only allowed
as part of a pct-encoded triplet and only for reserved/fragment
expansion: in all other cases, a value character of "%" MUST be pct-
encoded as "%25" by variable expansion."

@fxa
Copy link
Owner

fxa commented Jun 15, 2016

See your point, will fix it as soon as possible

On 15.06.2016 16:36, John Brinkman wrote:

Expanding:
{"uri": "http://foo/bar?message=hello%20world"}
with the template:
{+uri}
must result in:
"http://foo/bar?message=hello%20world"

Not:

"http://foo/bar?message=hello%2520world"

From: https://tools.ietf.org/html/rfc6570#section-3.2.1
"Note that the percent character ("%") is only allowed
as part of a pct-encoded triplet and only for reserved/fragment
expansion: in all other cases, a value character of "%" MUST be pct-
encoded as "%25" by variable expansion."


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#17

Franz Antesberger
Alexander Ferdinand Str 3
93051 Regensburg
info@franz-antesberger.de
0160 374 84 95

@fxa
Copy link
Owner

fxa commented Jun 15, 2016

And of course i will add your sample to the test suite ;-)

On 15.06.2016 16:36, John Brinkman wrote:

Expanding:
{"uri": "http://foo/bar?message=hello%20world"}
with the template:
{+uri}
must result in:
"http://foo/bar?message=hello%20world"

Not:

"http://foo/bar?message=hello%2520world"

From: https://tools.ietf.org/html/rfc6570#section-3.2.1
"Note that the percent character ("%") is only allowed
as part of a pct-encoded triplet and only for reserved/fragment
expansion: in all other cases, a value character of "%" MUST be pct-
encoded as "%25" by variable expansion."


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#17

Franz Antesberger
Alexander Ferdinand Str 3
93051 Regensburg
info@franz-antesberger.de
0160 374 84 95

@JohnBrinkman
Copy link
Author

Excellent. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants