Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump safer-golangci-lint.yml to 1.49.0.1 #368

Merged
merged 7 commits into from Oct 3, 2022
Merged

Conversation

x448
Copy link
Contributor

@x448 x448 commented Sep 24, 2022

Bump from 1.46.2 to 1.49.0.1.

1.49.0.1 (October 2, 2022) allows different version of goimports (gofmt) to be used than Go version for golangci-lint.

  • GOFMT_VERSION - version of Go for gofmt and for building goimports
  • GOTOOLS_VERSION - version of go tools
  • GOIMPORTS_DGST - SHA-256 of goimports command built with Go 1.8.6 and go tools v0.1.12.

1.49.0 (September 18, 2022) is identical to latest at github.com/x448/safer-golangci-lint.

# Release v1.49.0 (September 18, 2022)
#   - Bump golangci-lint to 1.49.0
#   - Bump Go to 1.19 (latest version of 1.19.x because check-latest: true).
#   - Put Go version in environment variable GO_VERSION.
#   - Increase timeout to 15m for big projects enabling more linters.
#   - Use SHA-256 to verify (instead of SHA-384) and mention checksums file.
#   - Hash of golangci-lint-1.49.0-linux-amd64.tar.gz
#     - SHA-384: df59267a11317d2763fb6cb454a9b3a6a6d428f4750fcbb8604fb0d289b18a1b3b6cd2bfbf2a2fe976979e97a71fcc36
#     - SHA-256: 5badc6e9fee2003621efa07e385910d9a88c89b38f6c35aded153193c5125178
#                This SHA-256 digest matches golangci-lint-1.49.0-checksums.txt at
#                https://github.com/golangci/golangci-lint/releases

Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

Left a comment to defer switch to Go 1.19 gofmt until after fuzzing and other contributed PRs are merged.

.github/workflows/safer-golangci-lint.yml Show resolved Hide resolved
x448 and others added 3 commits October 2, 2022 08:44
@x448 x448 changed the title Bump safer-golangci-lint.yml to 1.49.0 Bump safer-golangci-lint.yml to 1.49.0.1 Oct 3, 2022
Comment out gofmt and goimports because they are
handled by safer-golangci-lint.yml.
@x448
Copy link
Contributor Author

x448 commented Oct 3, 2022

@fxamacker please take another look. I needed to comment out gofmt and goimports from .golangci.yml because goimports is always run by safer-golangci-lint.yml after compiled using specified versions of go and go tools.

@fxamacker fxamacker merged commit de03533 into fxamacker:master Oct 3, 2022
@x448 x448 deleted the patch-30 branch October 22, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants