Improve function-value
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
turbolent
commented
Mar 31, 2023
•
turbolent
commented
- Type parameter type bounds are optional
- Parameter argument labels are optional: they should be encoded as empty string if not given
turbolent
commented
Mar 31, 2023
|
@fxamacker How could we document the second point in the spec? |
For both points, these optional values (nil for optional type and empty string for optional label) are allowed in the format by CDDL. I think requirements like these (separate from the data format) can be mentioned as a consideration for CCF-based protocols in a non-CDDL section. |
fxamacker
reviewed
Apr 1, 2023
| @@ -997,7 +997,7 @@ function-value = [ | |||
| type-parameters: [ | |||
| * [ | |||
| name: tstr, | |||
| type-bound: type-value | |||
| type-bound: type-value / nil | |||
There was a problem hiding this comment.
UPDATE: based on slack discussion, we should remove nil from type-value and cherry pick to allow optionality only when needed.
fxamacker
approved these changes
Apr 3, 2023
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.