-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment quote handling #13
Comments
Hi Matthew |
Yep... Still a problem... Try looking at the above code (First block) in the mode... |
solved in v3 |
This is still a problem in version 3.0. Not only does it not recognise comments, it stops every other mode from recognising comments and I have to restart Emacs! |
I ll look at it tonight. Could you send me a screenshot please |
Could you try the beta version available on http://web-mode.org/beta/web-mode.el |
Seems to to work! Thank you so much for that very very quick fix. And thinks for writing and realising such a useful mode, much appreciated! |
You're welcome ... do not hesitate to share it ... I need more testers |
The problem seems to have reoccurred and I'm not quite sure why or how. Here's a screenshot of the problem: http://awesomescreenshot.com/0b7oxqo4e It only happens when I have used web-mode, but it doesn't seem to happen always, or right away after use web-mode. I'll let you know if I manage to find a repeatable way of producing it! |
Could you send me the code please. Moreover what language do you use ? Web-mode is designed for html embedding just little blocks of code Le 7 déc. 2012 à 11:40, Thomas Parslow notifications@github.com a écrit :
|
The HTML I sent triggers it. But once it's triggered the comments show up Thomas Parslow http://almostobsolete.net On 7 December 2012 10:56, fxbois notifications@github.com wrote:
|
I have a three-line test case that breaks comments in all modes when current tip of web-mode is activated.
When I open a file with those contents, any file I open after that will not highlight comments correctly. If I edit a file that was already open, comment highlighting will break on everything after the point I edited at. I am running Aquamacs 2.4:
and I am loading web-mode this way (comment pertaining to attempts to make web-mode work in OS X's default command-line emacs):
|
Hi Nate, |
Hi Nate, Could you try the last version available on http://emacsformacosx.com/ |
@almost Hi, could tell me what version of emacs you used when the bug triggered ? |
It looks like it might be version-related - the version on the site you linked seems to work as expected. |
I am having the exact same problem described here with GNU Emacs 23.4.1. |
I'm on GNU Emacs 23.3.1. I'll upgrade later on today if I get a moment... |
@johnjcamilleri That sounds very plausible. I don't have time to try this right now, but this post suggests implies that defining web-mode-prog-mode and using that in web-mode might work better. |
@johnjcamilleri @almost @Archenoth @NateEag I've added the defalias to web-mode.el |
Hmm I would say this seems to behave a little better, although now for some reason I don't seem to get any syntax highlighting for comments in Emacs-Lisp (
So if I load Emacs and open only this file, the comments get highlighted correctly. Then if I open a |
@johnjcamilleri if possible could you try this with emacs 24 and 23 |
@fxbois The behaviour described above is GNU Emacs 23.4.1 on Ubuntu 12.10. I currently don't have access to Emacs 24, I'm not sure how to install it without overwriting my current Emacs installation... |
Same issue in Emacs 23 after commenting my workaround and pulling down the newest version. I also get the following error on loading web-mode:
|
@johnjcamilleri @NateEag a commit to take of the with-silent-modifications issue Does it solve anything ? |
@Archenoth @almost @johnjcamilleri @NateEag I've installed emacs 23 and have detected that font-lock-keywords-only was the origin of the problem. Even made buffer-local, this var was spread on other buffers. |
Confirmed working in Emacs 23 — thank you so much @fxbois ! |
Working in Emacs 23 for me, too - thank you! |
Comments don't handle quotes correctly.
You can reproduce this bug by putting the following code into a web-mode buffer.
web-mode thinks "
return
" is a string because of the "'
" in the comment.This only appears to affect things if the quote is closed before the page ends, so:
This actually highlights correctly until you put a "
'
" somewhere.The text was updated successfully, but these errors were encountered: