Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve elixir language #1191

Closed
wants to merge 2 commits into from
Closed

Improve elixir language #1191

wants to merge 2 commits into from

Conversation

Matsa59
Copy link

@Matsa59 Matsa59 commented May 17, 2021

  • Add f = pattern support for auto indent
  • Improve multilines

Fix issue : #1188

@Matsa59 Matsa59 force-pushed the master branch 2 times, most recently from 4506a99 to 0a4ad43 Compare May 17, 2021 21:48
@fxbois
Copy link
Owner

fxbois commented May 18, 2021

The patch is not ok
</form> is not a control block

@Matsa59
Copy link
Author

Matsa59 commented May 18, 2021

@fxbois What do you mean by control block? I have no idea how I could add as a closing block element for an elixir block

Edit : I undertand what you said for </form> where can I add this rule ?
For the moment is not so bad, it just break the auto indent for the if we don't have the <form ..>. I mean it fix the auto indent that return to line automatically

+ Add `f = ` pattern support for auto indent
+ Improve multilines
@wkirschbaum
Copy link
Contributor

wkirschbaum commented Aug 29, 2021

How relevant would this be in the future, as the new .heex syntax would be <.form let={f} for={:search} phx-change="chg-search" phx-submit="sbt-search">...<.form> and .leex seems to be on the path of being deprecated. I speak under correction.

update:

yes, the above syntax will be deprecated and not thinking the extra complexity is worth adding as it has to cater for an unbalanced form tag.

@fxbois fxbois closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants