Better reminders UI #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarty
force-pushed
the
reminders-ui
branch
2 times, most recently
from
e2dae96
to
b3b8b38
Compare
| return ( | ||
| <li className="reminders__item"> | ||
| <div className="reminders__item-time"> | ||
| <div>{moment(reminder.datetime).format('LT')}</div> |
There was a problem hiding this comment.
If the date is a single digit i.e. 7 July, rather than double digit then the item content is misaligned. Maybe force to double digit? i.e. 07 July.
There was a problem hiding this comment.
Yeah there's the same problem with the time. The only way of fixing it is to use a table for the layout. Do you have a better idea?
|
Nice, r+ (unless you want to address the comment, then r+ with comment :)). |
|
Thanks Sam for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samgiles: can you please review this patch?