Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerned about requiring nightly Rust #32

Closed
jedireza opened this issue Feb 8, 2016 · 3 comments
Closed

Concerned about requiring nightly Rust #32

jedireza opened this issue Feb 8, 2016 · 3 comments

Comments

@jedireza
Copy link
Contributor

jedireza commented Feb 8, 2016

I just wanted to voice a concern about using features that require us to use nightly Rust. I'd prefer us to only use features available in stable Rust so we can make cutting releases easy and not end up in a situation where we have to refactor (backwards).

For example in #29 we chose to use the docopt! macro when we could've just kept the original semantics and got the same functionality.

It's not only the docopt! macro. There are features in the serde_json crate too IIRC. I was planning to remove serde_json and use rustc_serialize::json instead.

Now that a lot of us are adding code I think we should be aware and agree how best to handle this, even if that decision is to keep nightly Rust.

Thoughts?

@hfiguiere
Copy link
Contributor

I used the macro because we already require nightly - I wouldn't have otherwise.

Maybe the proper thing at that point is to freeze the nightly requirement and make sure that Foxbox ride the train to Rust 1.8 release.

@hfiguiere
Copy link
Contributor

FWIW, 1.8 will be out in 10 weeks (12 from Jan 21st)

@jedireza
Copy link
Contributor Author

Tracking 1.8 to stable and then sticking with stable sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants