-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrote and organized instructions #37
rewrote and organized instructions #37
Conversation
``` | ||
|
||
This then builds and runs the project locally: | ||
Alternativly you can build the app without running it via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Alternatively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
||
We're using Rust for the daemon/server. Currently 1.8.x nightly is required. We | ||
plan to track v1.8.x into stable and then continue using stable releases from | ||
then on. As of 2016-02-04: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have no such plan to stick on 1.8. We may stay on nightlies longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I opened #32 and only heard from Hub, which sounded liked a decent plan.
It's easy to remove "We plan to track v1.8.x into stable and then continue using stable releases from then on.". Would you like to mention/address our intent on try getting on stable at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's really not useful at this point. We may have to stay on nightly for a while (look at servo for instance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks. PR updated.
Rebased to resolve conflicts. r? @fabricedesre |
## Toolchain | ||
```bash | ||
$ rustc -V | ||
rustc 1.8.0-nightly (dea183aa8 2016-02-02) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the version to use anymore. Current known good rustc revision is fae516277b6da46b6c1cf568765c90fad2f9ae4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This has been updated.
rewrote and organized instructions
This patch converts the taxonomy_router to return multipart data when the result of a fetch (or, theoretically, anything else) contains Binary. Other changes were required to get foxbox to compile.
Depends on #36