Fix UserDb API usage following changes for issue fxbox/users#53 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabricedesre this might be useful for issue #142. Albeit here I hardcode the file name instead of getting it from the configuration. |
|
This PR needs some work. Test failures. |
|
FWIW I'd like to take a different approach fxbox/users#66 (comment) |
|
@fabricedesre @ferjm r? (need the changes for fxbox/users#53 and a readjustment of the Cargo.toml once they land) |
|
(rebased again) Also I support the new stuff from PR #184 |
|
Now that the other PR has been merged, this is read for @fabricedesre @ferjm r? |
|
LGTM. Thanks! |
ferjm
added a commit
that referenced
this pull request
Mar 14, 2016
Fix UserDb API usage following changes for issue fxbox/users#53. r=ferjm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need fxbox/users#66 to be merged. This reference my own branch.