Add command line options to parse http and ws port numbers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you listen to an explicit IP address, then you only accept connections over one particular interface (lo for localhost). By using 0.0.0.0 connections will be accepted over any interface (wifi, eth, lo, etc).
Some services (like ntop) already use port 3000. Add command line options to allow the ports to be specified.
| const DEFAULT_HOSTNAME: &'static str = "localhost"; | ||
| const DEFAULT_HTTP_PORT: &'static str = "3000"; | ||
| const DEFAULT_WS_PORT: &'static str = "4000"; | ||
| const DEFAULT_HOSTNAME: &'static str = "0.0.0.0"; |
|
@dhylands my PR did change the way the command line is parsed. Do you want me to fix this PR? Let me know. |
|
@hfiguiere Sure - feel free. |
|
I think we can close this as the other PR will implement this. |
|
Fixed by cea37bf |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services, like ntop already use port 3000, so this allows alternate ports to be used.