Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tunnel url to registry. r=fabrice #11

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Conversation

ferjm
Copy link
Member

@ferjm ferjm commented Mar 14, 2016

No description provided.

@ferjm
Copy link
Member Author

ferjm commented Mar 14, 2016

Given that the storage content is really not valuable for us, we can safely remove the existing sqlite file from the dev server before applying these changes.

r? @fabricedesre

@michielbdejong
Copy link
Contributor

@ferjm can we also add the public-local URL? So the Box would post something like the JSON I described in fxbox/foxbox#77 (comment)

@michielbdejong
Copy link
Contributor

In fact, I'm thinking, why impose a schema at all? We could just make this service a lot "dumber", just a message bus where anybody can broadcast a message, and anybody can see which messages were sent from the same outgoing IP address.

That makes it a lot clearer what the assumptions are, and it decouples the code of this server from the function we use it for.

fabricedesre added a commit that referenced this pull request Mar 14, 2016
Add tunnel url to registry. r=fabrice
@fabricedesre fabricedesre merged commit 38e42a0 into fxbox:master Mar 14, 2016
@michielbdejong
Copy link
Contributor

I'm still thinking, why impose a schema at all? We could just change local_ip to msg, that way the Box can decide which message string it wants to announce via this service.

@ferjm
Copy link
Member Author

ferjm commented Mar 15, 2016

Yes, we could do that.

@fabricedesre any objection?

@fabricedesre
Copy link
Contributor

We can't let clients send arbitrary large message and basically use the registration server as a poor man's db. So I'm fine with having a more relaxed schema, but we can't be fully open ended I fear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants