Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error with Xcode 11 #3

Closed
skrew opened this issue Sep 22, 2019 · 2 comments
Closed

Compilation error with Xcode 11 #3

skrew opened this issue Sep 22, 2019 · 2 comments

Comments

@skrew
Copy link

skrew commented Sep 22, 2019

Hi,

Using the master branch (and GradientLoadingBar), i still have 2 errors:

Initializer does not override a designated initializer from its superclass
'Observable<T>' initializer is inaccessible due to 'private' protection level

in Observable.swift, line 106

Thanks
fxm90 added a commit that referenced this issue Sep 22, 2019
@fxm90
🐛 :: Make initializer of Observable fileprivate in order to allow…
5bdb77c 
… overriding it in subclass `Variable`.

Furthermore we disable the swiftlint-rule `redundantFileprivate` for this line, as it was causing the issue #3
@fxm90
Copy link
Owner

fxm90 commented Sep 22, 2019

Oh my gosh I'm so sorry!! This was an invalid auto-correction from Swiftformat, which I didn't had a further look into. I've redeployed the version, can you please check again? 🙂

@skrew
Copy link
Author

skrew commented Sep 22, 2019

Fix was fast !!!

Seems ok for me, no more build error (but i still have some errors in others libraries, so i can't test changes on a device).

BTW i can close this issue.
Thanks again ;)

@skrew skrew closed this as completed Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skrew @fxm90