Added url repository type support
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix the tests please :-) |
francoispluchino
requested changes
Aug 1, 2019
|
Can you revert your last commit because finally added by 1aa6503, and squash your PR ? |
SilverFire
force-pushed
the
fix/package-repository-type
branch
from
d984dc3
to
3398131
Compare
|
Rebased |
francoispluchino
approved these changes
Aug 2, 2019
|
@SilverFire Thank you! |
|
Thank you too, @francoispluchino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, François!
We've got an issue that
npm/asclipackage does not get fetched.The reason is that they set
repository.type = urlthat is not supported. I haven't found any specification on allowed repository type values, but if you think this change is acceptable – please, merge it.