Add heroku 18 binaries #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested Aesthetikx's branch and it works well for me. |
|
I tested it and is working well for me too |
|
@fxtentacle Could you merge this PR? Works like a charm. thanks :) |
|
Works well, thanks all 👍 |
|
Due to my particular deployment situation, this pdftk binary didn't work. I have now updated the build script and added binaries that were compiled natively on a heroku-18 dyno. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added pdftk binaries that seem to be working for me on the heroku 18 stack. (Closes #8).
The process I used to obtain the binaries was basically adding the ubuntu artful sources to a heroku:heroku-18 docker container, then installing libgcj-common, libgcj17, and pdftk as explained here. This is because for whatever reason those packages are not available on bionic yet. Regardless, the pdftk binary runs on the docker container and is also able to generate filled pdfs in a heroku environment running stack 18, although I have not tested it extensively beyond that.