memory leak issue (umijs#715)

* memory leak issue * fix memory leak * use noop * Update src/sandbox/patchers/dynamicAppend.ts Co-authored-by: Kuitos <kuitos.lau@gmail.com>
fxxjdedd · Jul 4, 2020 · da03ce3 · da03ce3
1 parent 99dd475
commit da03ce3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/sandbox/common.ts b/src/sandbox/common.ts
@@ -50,7 +50,10 @@ export function getProxyPropertyGetter(proxy: WindowProxy, property: PropertyKey
   return undefined;
 }
 
-export function setProxyPropertyGetter(proxy: WindowProxy, property: PropertyKey, getter: () => any) {
+export function setProxyPropertyGetter(proxy: WindowProxy, property: PropertyKey, getter: () => any): Function {
   const prevGetters = proxyPropertyGetterMap.get(proxy) || {};
   proxyPropertyGetterMap.set(proxy, { ...prevGetters, [property]: getter });
+  return function deleteProxyPropertyGetter() {
+    proxyPropertyGetterMap.delete(proxy);
+  };
 }
diff --git a/src/sandbox/patchers/dynamicAppend.ts b/src/sandbox/patchers/dynamicAppend.ts
@@ -3,7 +3,7 @@
  * @since 2019-10-21
  */
 import { execScripts } from 'import-html-entry';
-import { isFunction } from 'lodash';
+import { isFunction, noop } from 'lodash';
 import { checkActivityFunctions } from 'single-spa';
 import { frameworkConfiguration } from '../../apis';
 import { Freer } from '../../interfaces';
@@ -321,9 +321,10 @@ export default function patch(
   scopedCSS = false,
 ): Freer {
   let dynamicStyleSheetElements: Array<HTMLLinkElement | HTMLStyleElement> = [];
+  let deleteProxyPropertyGetter: Function = noop;
 
   if (!singular) {
-    setProxyPropertyGetter(proxy, 'document', () => {
+    deleteProxyPropertyGetter = setProxyPropertyGetter(proxy, 'document', () => {
       return new Proxy(document, {
         get(target: Document, property: PropertyKey): any {
           if (property === 'createElement') {
@@ -442,6 +443,8 @@ export default function patch(
       // the dynamic style sheet would be removed automatically while unmoutting
     });
 
+    deleteProxyPropertyGetter();
+
     return function rebuild() {
       dynamicStyleSheetElements.forEach(stylesheetElement => {
         // re-append the dynamic stylesheet to sub-app container