Adding a readiness probe #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
shlomitk1
requested review from
cdoron and
revit13
and removed request for
revit13
revit13
reviewed
May 1, 2023
| @@ -37,6 +37,11 @@ spec: | |||
| - name: grpc | |||
| containerPort: 8080 | |||
| protocol: TCP | |||
| readinessProbe: | |||
| failureThreshold: 3 | |||
There was a problem hiding this comment.
Please consider adding these values to values.yaml as in fybrik
There was a problem hiding this comment.
The main value in readinessProbe is the port that is defined here and not in the values.
revit13
approved these changes
May 1, 2023
|
You might also want to consider adding liveness probe... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes fybrik/fybrik#2082
This PR adds a readiness probe to the deployed pod.
It also fixes a test.