Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test to validate network isolation. #2066

Merged
merged 37 commits into from
May 10, 2023

Conversation

Mohammad-nassar10
Copy link
Contributor

@Mohammad-nassar10 Mohammad-nassar10 commented Apr 5, 2023

Implement tests to check network isolation of the fybrikmodules pods.
Closes #2055

Mohammad-nassar10 and others added 8 commits April 5, 2023 11:35
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
hack/tools/create_kind.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@shlomitk1 shlomitk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is very similar to the read test that we already have. I suggest to change the existing one to add an isolation check.

dependabot bot and others added 10 commits April 17, 2023 15:54
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 20.10.24+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.21...v20.10.24)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
@roytman
Copy link
Collaborator

roytman commented Apr 17, 2023

The test is very similar to the read test that we already have. I suggest to change the existing one to add an isolation check.

Let's leave it for now as a separate test, when we finish the isolation adaptation, we can integrate it with one of the existing tests.

Mohammad-nassar10 and others added 2 commits April 18, 2023 10:18
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
@roytman
Copy link
Collaborator

roytman commented Apr 19, 2023

The ArrowFlight module is very simple, it doesn't related on any external sites, except DNS and its data source". I suggest using the chaining example with airbyte module witch needs access to several external sites: docker.io, githup.com and others. I added its manifest as manager/testdata/airbyte-module-with-np.yaml

Mohammad-nassar10 and others added 6 commits April 30, 2023 11:09
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
connection:
name: https
https:
url: "https://github.com/Teradata/kylo/raw/master/samples/sample-data/parquet/userdata2.parquet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNS of github is very unpredictable, can you use the DNS mock as

srv, _ := mockdns.NewServer(map[string]mockdns.Zone{
, and always return one of github IPs., another option is to store the parquet files in a local HTTP server.

Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
@roytman
Copy link
Collaborator

roytman commented May 4, 2023

The test is not included in the CI pipeline.

Mohammad-nassar10 and others added 4 commits May 4, 2023 18:35
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
@roytman roytman merged commit 8663736 into fybrik:master May 10, 2023
11 checks passed
Mohammad-nassar10 added a commit to Mohammad-nassar10/fybrik that referenced this pull request May 11, 2023
* Adding test to validate network isolation.

Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>

---------

Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tests of Fybrik Isolation
4 participants