-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test to validate network isolation. #2066
Conversation
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
…into isolation-test
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is very similar to the read test that we already have. I suggest to change the existing one to add an isolation check.
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.21...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v4...v5) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
…into isolation-test
Let's leave it for now as a separate test, when we finish the isolation adaptation, we can integrate it with one of the existing tests. |
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
The ArrowFlight module is very simple, it doesn't related on any external sites, except DNS and its data source". I suggest using the chaining example with airbyte module witch needs access to several external sites: docker.io, githup.com and others. I added its manifest as |
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
…into isolation-test
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
…into isolation-test
connection: | ||
name: https | ||
https: | ||
url: "https://github.com/Teradata/kylo/raw/master/samples/sample-data/parquet/userdata2.parquet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNS of github is very unpredictable, can you use the DNS mock as
srv, _ := mockdns.NewServer(map[string]mockdns.Zone{ |
manager/testdata/notebook/read-flow/np-modules-ex/airbyte-module-with-np.yaml
Outdated
Show resolved
Hide resolved
manager/testdata/notebook/read-flow/np-modules-ex/arrow-flight-np-transform.yaml
Show resolved
Hide resolved
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
The test is not included in the CI pipeline. |
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
…into isolation-test
* Adding test to validate network isolation. Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com> --------- Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Implement tests to check network isolation of the
fybrikmodules
pods.Closes #2055