Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerPayment #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CustomerPayment #90

wants to merge 3 commits into from

Conversation

ghtbsokczhh
Copy link

No description provided.

@Shwetabhk
Copy link
Contributor

@ghtbsokczhh
The PR is incomplete, we're currently evaluating more and will add details shortly.

You'll also have to add the Type for Customer Payment here for first impressions.
https://github.com/fylein/netsuite-sdk-py/blob/master/netsuitesdk/internal/netsuite_types.py

@VeNoMouS
Do you have any findings about the type to be added?

@Sravanksk
Copy link
Contributor

@ghtbsokczhh
As stated above, the PR is incomplete, you have to make a bunch of changes in the netsuite_type.py file. You should be adding types related to CustomerPayment under the ns23 section

You can refer to this schema and add the required types - https://www.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2020_1/schema/record/vendorcredit.html

POST of CustomerPayments is not implemented in your PR, you can refer to this PR 617e411

@ghtbsokczhh
Copy link
Author

sounds good. I will add update soon.

@ghtbsokczhh
Copy link
Author

What does the netsuite_type.py do? The code currently works for CustomerPayment.get(internalId=xxx) requests with the update.

@ghtbsokczhh
Copy link
Author

@Sravanksk

I'm trying to understand what the name space means/does. Why does it need to be in ns23?

@ghtbsokczhh
Copy link
Author

https://webservices.netsuite.com/xsd/transactions/v2022_1_0/customers.xsd

which namespace should these attributes be added?

getting up to date with the origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants