Add tagline support for brand icon #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmalmgren
suggested changes
Apr 13, 2017
| .tagline { | ||
| fill: @red; | ||
| text-anchor: middle; | ||
| font-size: 6.5px; |
There was a problem hiding this comment.
Having it at 5.5px makes it look more like the logo we display on the monolith (desktop)
There was a problem hiding this comment.
I took for reference the mobile website haha.
Since the 2 websites are already not consistent, I can add a prop to the component, like taglineSize which would be the size in px. And default would be either 6.5px or 5.5
This enables the use to chose the font-size of the tagline
|
@simonolsson ping |
simonmalmgren
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for tagline under the Fyndiq Logo.
How to test
npm run devand go to localhost:6006