Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FyneApp.toml #78

Closed
lucor opened this issue Oct 5, 2021 · 3 comments · Fixed by #87
Closed

Add support for FyneApp.toml #78

lucor opened this issue Oct 5, 2021 · 3 comments · Fixed by #87
Labels
enhancement New feature or request

Comments

@lucor
Copy link
Member

lucor commented Oct 5, 2021

Is your feature request related to a problem? Please describe:

Starting from v2.1.0 Fyne CLI adds a FyneApp.toml metadata file to hold defaults for the package process.
fyne-cross should be updated to support the FyneApp.toml file.

Is it possible to construct a solution with the existing API?

Yes.

Describe the solution you'd like to see:

Update fyne-cross to support the FyneApp.toml file out of the box.
@lucor
Copy link
Member Author

lucor commented Oct 5, 2021

Reference: fyne-io/fyne#2398

@lucor lucor added the enhancement New feature or request label Oct 5, 2021
@Jacalz
Copy link
Member

Jacalz commented Dec 14, 2021

We should probably target this for the next release. I think the fyne package command is supposed to bump the build number in this file. Is that something that we can pass back from within the docker container?

Jacalz added a commit to Jacalz/rymdport that referenced this issue Dec 14, 2021
@Jacalz
Revert some makefile changes due to fyne-io/fyne-cross/issues/78
84bb866 
I had assumed initially that this was supported but lets rever back temporarily
due to fyne-io/fyne-cross#78.
lucor added a commit to lucor/fyne-io-fyne-cross that referenced this issue Jan 10, 2022
@lucor
Add support for FyneApp.toml
33ccea5 
This commit adds support for the  the FyneApp.toml file

Fixes fyne-io#78
@lucor lucor mentioned this issue Jan 10, 2022
Merged
3 tasks
@lucor
Copy link
Member Author

lucor commented Mar 5, 2022

Available on develop and #90 for testing

@lucor lucor closed this as completed Mar 5, 2022
@lucor lucor mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for FyneApp.toml lucor/fyne-io-fyne-cross
2 participants
@lucor @Jacalz