Merge pull request #4830 from dweymouth/fix-hyperlink-tap

Fix regression of hyperlink tap rejection if outside text area

widget/hyperlink.go

@@ -211,6 +211,9 @@ func (hl *Hyperlink) SetURLFromString(str string) error {
 
 // Tapped is called when a pointer tapped event is captured and triggers any change handler
 func (hl *Hyperlink) Tapped(e *fyne.PointEvent) {
+	if len(hl.provider.Segments) != 0 && !hl.isPosOverText(e.Position) {
+		return // tapped outside text area
+	}
 	hl.invokeAction()
 }
 

widget/hyperlink_test.go

@@ -103,6 +103,19 @@ func TestHyperlink_OnTapped(t *testing.T) {
 	assert.Equal(t, 1, tapped)
 }
 
+func TestHyperlink_TappedOutsideTextBoundary(t *testing.T) {
+	tapped := 0
+	link := &Hyperlink{Text: "Test"}
+	link.OnTapped = func() {
+		tapped++
+	}
+	link.syncSegments()
+	link.Tapped(&fyne.PointEvent{
+		Position: fyne.NewPos(50 /*past text boundary*/, 2),
+	})
+	assert.Equal(t, 0, tapped)
+}
+
 func TestHyperlink_KeyboardOnTapped(t *testing.T) {
 	tapped := 0
 	link := &Hyperlink{Text: "Test"}