Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to disable ToolbarActions #2306

Open
EugeneSindambiwe opened this issue Jul 1, 2021 · 9 comments
Open

Add the ability to disable ToolbarActions #2306

EugeneSindambiwe opened this issue Jul 1, 2021 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@EugeneSindambiwe
Copy link

ToolbarActions and MenuItems needs to be disableable for the similar reasons and coherence with DisableableWidgets. Last corresponds to solved #234 .
@Jacalz Jacalz changed the title Add the ability to disable ToolbarActions & MenuItems (see also solved issue #234) Add the ability to disable ToolbarActions & MenuItems Jul 2, 2021
@Jacalz
Copy link
Member

Jacalz commented Jul 2, 2021

Hi. Please use the issue templates when opening issues (the Feature Request template in this case). It makes makes it much easier for us to understand and categorise new issues.

As for this issue, I think it might, at least partially, be a duplicate of #682 when it comes to disabling menus. However, toolbars does not. I think it might be good to transition this to instead be for that part only.

@Jacalz Jacalz added the enhancement New feature or request label Jul 2, 2021
@andydotxyz
Copy link
Member

andydotxyz commented Jul 4, 2021 •
edited

I think it might be good to transition this to instead be for that part only.

Agreed. Disablable menus are already on PR #2261 heading to the 2.1 release.
Disabling ToolbarAction is a nice addition idea :).

@andydotxyz andydotxyz added this to the Aberlour (2.1) milestone Jul 4, 2021
@EugeneSindambiwe
Copy link
Author

Excellent. Thanks a lot for the responsiveness and positive feedback.

@andydotxyz andydotxyz changed the title Add the ability to disable ToolbarActions & MenuItems Add the ability to disable ToolbarActions Jul 6, 2021
@andydotxyz andydotxyz added the good first issue Good for newcomers label Jul 8, 2021
@thevibhu
Copy link

thevibhu commented Oct 2, 2021

Can I take up this issue?

@Jacalz
Copy link
Member

Jacalz commented Oct 2, 2021

Absolutely. I don't think anyone has started working on this. Go ahead :)

@andydotxyz andydotxyz removed this from the Bowmore Release (early 2022) milestone Jun 3, 2022
@75asu
Copy link

75asu commented Sep 30, 2022

Hi @Jacalz , I'm new to this. could you please suggest me the file where this change needs to be implemented and elaborate a little technically how this can done?

@andydotxyz
Copy link
Member

Look at widget/toolbar.go I would think - see how the normal button disables as inspiration.

pravin772 added a commit to pravin772/fyne that referenced this issue Dec 31, 2022
@pravin772
Add the ability to disable ToolbarActions fyne-io#2306
9502efa
@pravin772 pravin772 mentioned this issue Dec 31, 2022
Closed
3 tasks
@vivekprm
Copy link

Is it still open? Can I work on this?

@andydotxyz
Copy link
Member

Yes it is still open (you can see because the issue is open).
Feel free to work on it, thanks.

@Rakshana2300 Rakshana2300 mentioned this issue Sep 18, 2023
Closed
3 tasks
maruu pushed a commit to maruu/fyne that referenced this issue Oct 28, 2023
Add the ability to disable ToolbarActions fyne-io#2306
591f1e3
maruu pushed a commit to maruu/fyne that referenced this issue Oct 28, 2023
Add the ability to disable ToolbarActions fyne-io#2306
7a7f54a
maruu pushed a commit to maruu/fyne that referenced this issue Oct 28, 2023
add the ability to disable ToolbarActions fyne-io#2306
2f62b73
@maruu maruu mentioned this issue Oct 28, 2023
Merged
4 tasks
maruu pushed a commit to maruu/fyne that referenced this issue Nov 8, 2023
add the ability to disable ToolbarActions fyne-io#2306
1765685
maruu added a commit to maruu/fyne that referenced this issue Jan 16, 2024
@maruu
fyne-ioGH-2306: remove unnecessary refresh
b9a104a
maruu added a commit to maruu/fyne that referenced this issue Jan 16, 2024
@maruu
fyne-ioGH-2306: sync Icon property
636deb5
maruu pushed a commit to maruu/fyne that referenced this issue Jan 16, 2024
@maruu
add the ability to disable ToolbarActions fyne-io#2306
873bdcd
maruu added a commit to maruu/fyne that referenced this issue Jan 16, 2024
@maruu
fyne-ioGH-2306: remove unnecessary refresh
df55695
maruu added a commit to maruu/fyne that referenced this issue Jan 16, 2024
@maruu
fyne-ioGH-2306: sync Icon property
a701d5f
maruu added a commit to maruu/fyne that referenced this issue Jan 19, 2024
@maruu
fyne-ioGH-2306: use lazy initialization of button
d9f4e9d 
Since the ToolbarAction can also be created
without the constructor, the pointer to the
button could be nil.
maruu added a commit to maruu/fyne that referenced this issue Jan 31, 2024
@maruu
fyne-ioGH-2306: save button directly instead of pointer to avoid lazy…
d424c9b 
… initialization
maruu added a commit to maruu/fyne that referenced this issue Jan 31, 2024
@maruu
fyne-ioGH-2306: add clarification comment to test
a8975a5
maruu added a commit to maruu/fyne that referenced this issue Feb 1, 2024
@maruu
fyne-ioGH-2306: remove whitespaces
62610f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@andydotxyz @vivekprm @EugeneSindambiwe @thevibhu @Jacalz @75asu