Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropped letters in certain cases with the new v2.3.0 theme #3500

Closed
2 tasks done
alexballas opened this issue Dec 25, 2022 · 7 comments
Closed
2 tasks done

Cropped letters in certain cases with the new v2.3.0 theme #3500

alexballas opened this issue Dec 25, 2022 · 7 comments
Labels
blocker Items that would block a forthcoming release bug Something isn't working

Comments

@alexballas
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

In certain cases, when using markdown heading level 1, the last letter in the header may appear cropped

How to reproduce

Check screenshot and provided code

Screenshots

Screenshot from 2022-12-25 18-02-19

Example code

package main

import (
	"fyne.io/fyne/v2/app"
	"fyne.io/fyne/v2/widget"
)

var currentmfolder string

func main() {
	myApp := app.New()
	myWindow := myApp.NewWindow("Test Dialog")
	richhead := widget.NewRichTextFromMarkdown(`
# AAAAA
# BBBBB
# EEEEE
# FFFFF
# GGGGG
# HHHHH
# IIIII
# JJJJJ
# KKKKK
# LLLLL
# MMMMM
# NNNNN
# OOOOO
# PPPPP
# QQQQQ
# VVVVV
`)
	myWindow.SetContent(richhead)
	myWindow.ShowAndRun()

}

Fyne version

v2.3.0

Go compiler version

1.19.4

Operating system

Linux

Operating system version

Ubuntu 18.04

Additional Information

No response

@alexballas alexballas added the unverified A bug that has been reported but not verified label Dec 25, 2022
@alexballas alexballas changed the title Cropped letters in certain cases when using markdown rich text. Cropped letters in certain cases Dec 25, 2022
@alexballas alexballas changed the title Cropped letters in certain cases Cropped letters in certain cases with the new v2.3.0 theme Dec 25, 2022
@alexballas
Copy link
Contributor Author

Actually this does not affect just the richtext stuff. I just noticed that normal buttons are also affected. (please check the play button)
Screenshot from 2022-12-25 21-01-10

@andydotxyz
Copy link
Member

Indeed, this will impact all text as it's rendered in the same pipeline. Looks like something to do with wide fonts though - headers or bold text. I see this on my system too.

@andydotxyz andydotxyz added bug Something isn't working blocker Items that would block a forthcoming release and removed unverified A bug that has been reported but not verified labels Jan 4, 2023
@andydotxyz andydotxyz added this to the Fixes (v2.3.x) milestone Jan 4, 2023
@andydotxyz
Copy link
Member

Should be fixed by the move to go-text renderer in v2.3.2:

Screenshot 2023-02-06 at 23 03 05

@alexballas
Copy link
Contributor Author

Thanks Andy! Is this currently available in the develop branch to test it out?

@andydotxyz
Copy link
Member

It's not landed yet, but you can test my PR if you like #3633

@alexballas
Copy link
Contributor Author

Just mentioning it also here for visibility. Current develop branch is still affected by the issue even after the PR above was merged.

andydotxyz pushed a commit to andydotxyz/fyne that referenced this issue Mar 15, 2023
@andydotxyz
Copy link
Member

I was going to hold this open as not fixed, but the workaround is pretty solid ;) in v2.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants