Changing TabItem Text

[s77rt]

Hi,
Can we change the text of an existing TabItem?

[andydotxyz]

It should be possible to change the value in TabItem.Text and then call TabContainer.Refresh() - if that is not refreshing you have found a bug.

[s77rt]

yes, seems as a bug, any progress on this?

[Jacalz]

@s77rt Would you mind adding additional information to the issue like operating system, fyne version and go version and possibly a small code snippet example on what exactly you are doing? It makes it much easier to help you out :)

[s77rt]

@Jacalz
OS: Linux
fyne: tested on 1.2.2, 1.2.3, 1.2.4 (probably other versions too)
go: 1.13

Code example:

package main

import (
	"fyne.io/fyne"
	"fyne.io/fyne/app"
	"fyne.io/fyne/widget"
)

func main() {
	app := app.New()
	w := app.NewWindow("Tabs?")
	var tabs *widget.TabContainer
	var tab1, tab2 *widget.TabItem
	tab1 = widget.NewTabItem("Tab 1 (Change me)",
		widget.NewVBox(
			widget.NewButton("Change Tab1 Text", func() {
				tab1.Text = "Tab 1 (Changed)"
				tabs.Refresh()
			}),
			widget.NewButton("Change Tab2 Text", func() {
				tab2.Text = "Tab 2 (Changed)"
				tabs.Refresh()
			}),
		),
	)
	tab2 = widget.NewTabItem("Tab 2 (Change me)", widget.NewLabel("Just another tab"))
	tabs = widget.NewTabContainer(
		tab1,
		tab2,
	)
	tabs.SetTabLocation(widget.TabLocationLeading)
	w.SetContent(tabs)
	w.Resize(fyne.Size{200, 150})
	w.ShowAndRun()
}

the purpose is to change the text of the tabs 1 and 2.
click on the buttons, you should expect a change on the text of the tabs, but nothing happen

[andydotxyz]

I have a potential fix locally, just tidying up and testing.

[s77rt]

just tested, works as expected :)