Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard support to buttons #885

Closed
tataDan opened this issue Apr 20, 2020 · 3 comments
Closed

Add keyboard support to buttons #885

tataDan opened this issue Apr 20, 2020 · 3 comments
Labels
enhancement New feature or request Keyboard Items for keyboard control
Milestone
Aberlour (2.1)

Comments

@tataDan
Copy link

tataDan commented Apr 20, 2020

Buttons do not receive focus when the user presses the key. (Presumably, they do not implement the Focusable interface). It would be nice if they could receive focus. Additionally, it would be nice if once a button does receive focus, the user could use the space key to invoke the button's handler.

This issue is similar to the one fixed by PR #287 that dealt with checkboxes.
@tataDan
Copy link
Author

tataDan commented Apr 20, 2020

The original post should have stated "when the user presses the <Tab> key", not "when the user presses the key".

@andydotxyz andydotxyz changed the title Buttons Are Not Focusable Add keyboard support to buttons Apr 20, 2020
@andydotxyz andydotxyz added the enhancement New feature or request label Apr 20, 2020
@andydotxyz andydotxyz mentioned this issue Jun 10, 2020
Closed
5 tasks
@AlbinoGeek AlbinoGeek mentioned this issue Nov 17, 2020
Open
10 tasks
@andydotxyz andydotxyz added the Keyboard Items for keyboard control label Nov 17, 2020
@toaster
Copy link
Member

toaster commented Jun 14, 2021

I think this is done with #2263.

@andydotxyz
Copy link
Member

Indeed good catch - this is on develop branch for testing before 2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Keyboard Items for keyboard control
Projects
None yet
Milestone
Aberlour (2.1)
Development

No branches or pull requests
3 participants
@toaster @andydotxyz @tataDan