Add focus support for checkbox #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the checkbox widget to receive focus implementing the focusable interface. This will allow: - to receive focus via Tab and Shift Tab - to be checked and unchecked using the "Space" key on desktop when focused
andydotxyz
requested changes
Jun 2, 2019
There was a problem hiding this comment.
Looking good. 2 issues outside the comments inline:
- The focus code in internal/driver/focus.go should probably be checking Disablable as you can currently focus disabled widgets and I think this is the first time that was the case.
- The focus colour is no longer applicable because the current one is used for marking focus on background objects - but these are foreground. I am not sure if we should have 2 shades of focus colour, change the current one, or mark the focusing in a different way?
andydotxyz
reviewed
Jun 2, 2019
|
This is looking great. I think there is just the comment about hover vs focus colour that I know you are already working on. Will come back to it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the checkbox widget to receive focus implementing the Focusable interface.
This will allow: