Fix a lot of recommendations from staticcheck #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed some more unused functions. - Partly reverted progressbarinfinite chenges (might have caused a small issue)
Jacalz
commented
Jun 22, 2020
andydotxyz
requested changes
Jun 22, 2020
…ll fix This fixes the strings.Replace function to use n == -1 instead of 0 which gives no results at all. Added back the language icon and do a small fix to use the correct package in the bundled code.
Jacalz
changed the title
|
The changes have been made and testing on Linux and macOS gives no indication of any regressions :) |
andydotxyz
approved these changes
Jun 25, 2020
|
Great thanks - apologies for the delay. Just tapped update as well so as soon as it's green you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running
staticcheck -f stylish ./...on the codebase got a lot of result of small changes to improve the code. Some where ignored due to being part of the gomobile code, but most of the strictly fyne related fixes are fixed.Testing:
There is more testing that needs to be done on Windows and MacOS and some parts where I would like some feedback before touching it. I would have created a draft PR, but I remember seeing issues with Travis on those so I will keep it as a regular PR for now.
Please check that I haven't removed something that I shouldn't have removed.
Checklist: