fix #1354: switching overlays no longer removes focus from previous f… #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious focus manager Thus the focused element in the content stays highlighted while a pop-up menu is opened. Also the focused element stays highlighted if the menu is opened. However, the _one_ focus for keyboard events is moved to the overlay on top.
andydotxyz
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the focus handler changes (for instance because an overlay is added which contains a pop-up menu) the previous handler no longer receives
FocusLost. Thus the focused element is still highlighted but all focus related events (keyboard) are sent to the element focused by the new focus handler.Fixes #1354
Checklist: