Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: #814 #1454

Merged
merged 2 commits into from Oct 24, 2020
Merged

Bugfix: #814 #1454

merged 2 commits into from Oct 24, 2020

Conversation

toaster
Copy link
Member

@toaster toaster commented Oct 23, 2020

Description:

This PR introduces an own focus handler for (desktop) menus. Thus keyboard input no longer reaches the content if the menu is active.

Fixes #814

Note: Clicking on the menu removes the content’s focus but that’s an issue with the click handling.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@toaster toaster changed the base branch from master to develop October 23, 2020 20:25
@toaster toaster changed the title Bugfix/814 Bugfix: #814 Oct 23, 2020
@toaster
Copy link
Member Author

toaster commented Oct 23, 2020

oops … forgot to fix commit message … sorry!

@toaster toaster merged commit 69f1de6 into fyne-io:develop Oct 24, 2020
@toaster toaster deleted the bugfix/814 branch October 25, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key events not blocked by overlays
2 participants