Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list to use dividers the same way tree/table do. #1475

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

okratitan
Copy link
Member

Description:

Make list reuse dividers and place them correctly rather than using a border on list items.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this breaks some size calculations, I can no longer access the bottom of the list.

@andydotxyz
Copy link
Member

Image for the comment - the demo should have 1000 items, but alas:

Screenshot 2020-10-27 at 09 09 46

@andydotxyz
Copy link
Member

Also I noticed that list items are smaller than tree and table items again - we had this lined up nicely a while back

@andydotxyz andydotxyz mentioned this pull request Oct 27, 2020
3 tasks
@okratitan
Copy link
Member Author

Fyne Demo accessing the last item in the list:
image

List and tree items being the same size not smaller:
image

Are you sure you are up today with the PR? Is something else breaking it? It passes all test and works and looks as it should here

@andydotxyz
Copy link
Member

This is up to date - it appears that it's harder to repliate than I thought - but the issue is in there somewhere.
Scroll related it seems. Steps to replicate:

  • Scroll to end of list bu dragging the scrollbar
  • Using scroll wheel drag up around half a screen
  • Scroll down again
  • Notice that it no longer reaches the end of the list
  • Repeat and you will see the error is cumulative.

@andydotxyz
Copy link
Member

Also I noticed that list items are smaller than tree and table items again - we had this lined up nicely a while back

Apologies, this is not an issue - I must have been comparing develop where it is still broken.

widget/list.go Outdated Show resolved Hide resolved
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the height fixed it looks like the indicators are now too short...

Screenshot 2020-10-27 at 14 43 01

stuartmscott
stuartmscott previously approved these changes Oct 27, 2020
@andydotxyz andydotxyz merged commit 855370e into fyne-io:develop Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants