Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutex access to font library #194

Merged
merged 2 commits into from Mar 29, 2019
Merged

Mutex access to font library #194

merged 2 commits into from Mar 29, 2019

Conversation

andydotxyz
Copy link
Member

Possible fix for #189

@andydotxyz andydotxyz mentioned this pull request Mar 28, 2019
Closed
@paulhovey
Copy link
Contributor

Looks good to me!

I've often wondered if it's better to store a sync.RWMutex object or a pointer to the object. Normally structs are passed around as pointers, but I don't know if there's any benefit to mutexes?

@andydotxyz
Copy link
Member Author

Thanks @paulhovey that is a good point. I looked at it again and decided to embed the lock instead. Makes it more clearly a key part of this type.

@andydotxyz andydotxyz merged commit 30a6022 into master Mar 29, 2019
@Russtopia Russtopia mentioned this pull request Mar 29, 2019
Closed
@andydotxyz andydotxyz deleted the font-mutex branch May 5, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @paulhovey