RFC: Various changes to CI linting #2855
Conversation
Gofumpt has been working out very well for me and I am impressed with what it does. It is actively maintained and works well as a replacement to goimports. I also removed golint as it is deprecated. Staticcheck handles our needs now.
Jacalz
changed the title
No install recommends had no effect.
This comment was marked as outdated.
This comment was marked as outdated.
| - name: Staticcheck | ||
| run: staticcheck -go 1.14 ./... |
There was a problem hiding this comment.
FYI, this was removed as it picks it up from the module by default.
There was a problem hiding this comment.
In general this looks like a good change (except the noted CI failure).
However as it's changing the development style I wonder if it should be discussed with the group? Documentation and example git hooks would all need to be updated to avoid lots of PRs failing on open...
Indeed. To try an alleviate the problems as much as possible, I have both opened this as RFC and added it to the agenda for the Friday meeting next week. I’m very well aware that this might be disruptive to peoples workflows. I want this to get all the attention that it needs :) |
Ah I did not notice that good call! |
|
Looks like tests are passing now :) |
|
Doesn't make sense at the moment. Will just drop golint in a different PR. |
Description:
I want to open this for various suggested changes regarding the linting we do as part of the CI checks. My suggestion is to replace
goimportswith gofumpt and to stop using golint. As for the former, I think the stricter formatting is doing a great job (see diff for more info) and for the latter, it has been deprecated for a while now. Most of what golint did (if not even everything) is handled bygo vetandstaticcheckalready.These changes should also make the static analysis quite a bit faster.
Checklist: