Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements/fix coding style #2945

Merged
merged 1 commit into from Apr 28, 2022
Merged

Improvements/fix coding style #2945

merged 1 commit into from Apr 28, 2022

Conversation

Bluebugs
Copy link
Contributor

Description:

Just some cosmetic change to appease go 1.18 tools.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@Bluebugs Bluebugs changed the base branch from master to develop April 28, 2022 19:13
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.638% when pulling 5596403 on improvements/fix-coding-style into 8d89963 on develop.

Jacalz
Jacalz approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

@Bluebugs Bluebugs merged commit c36764a into develop Apr 28, 2022
@Bluebugs Bluebugs deleted the improvements/fix-coding-style branch April 28, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

@andydotxyz andydotxyz Awaiting requested review from andydotxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bluebugs @coveralls @Jacalz