Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glitch in render when table starts bigger than content #3458

Merged
merged 2 commits into from Dec 6, 2022
Merged

Fix glitch in render when table starts bigger than content #3458

merged 2 commits into from Dec 6, 2022

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Dec 4, 2022 •
edited

Fixes #3443

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Dec 4, 2022 •
edited

Coverage Status

Coverage increased (+0.2%) to 61.991% when pulling 853654e on andydotxyz:fix/3443b into 6cb06bd on fyne-io:develop.

Jacalz
Jacalz reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

@andydotxyz
Copy link
Member Author

I couldn't replicate it in the software test harness. Something about how the resize is handled.
I can try again and see how I get on I guess

@andydotxyz andydotxyz merged commit e62d8e7 into fyne-io:develop Dec 6, 2022
@andydotxyz andydotxyz deleted the fix/3443b branch December 6, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andydotxyz @coveralls @Jacalz