Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call systray.Quit() when the application is closing #3597

Merged
merged 1 commit into from Jan 24, 2023
Merged

Call systray.Quit() when the application is closing #3597

merged 1 commit into from Jan 24, 2023

Conversation

EssGeeEich
Copy link
Contributor

Description:

systray.Quit() is not being called consistently when the application is closing.

This results in the inability to automatically remove the systray icon for systray-only applications.

See also: fyne-io/systray#36

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@EssGeeEich EssGeeEich mentioned this pull request Jan 23, 2023
Merged
andydotxyz
andydotxyz approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@coveralls
Copy link

Coverage Status

Coverage: 61.858% (-0.006%) from 61.864% when pulling ef4295e on EssGeeEich:develop-2 into 89b41bc on fyne-io:develop.

@andydotxyz andydotxyz merged commit 784453c into fyne-io:develop Jan 24, 2023
@EssGeeEich EssGeeEich deleted the develop-2 branch January 31, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EssGeeEich @coveralls @andydotxyz