Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid all the “Android” OS reports #3670

Merged
merged 1 commit into from Feb 19, 2023
Merged

Conversation

andydotxyz
Copy link
Member

As discussed on slack

@coveralls
Copy link

Coverage Status

Coverage: 61.789%. Remained the same when pulling 3d72722 on simpler-os-selection into 11d055f on develop.

@andydotxyz andydotxyz changed the base branch from develop to master February 18, 2023 23:24
@andydotxyz andydotxyz changed the base branch from master to develop February 18, 2023 23:25
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a bit on a possible improvement while you're at it but will approve now as it isn't super important :)

placeholder: "e.g. Windows 10, 10.13 High Sierra or Ubuntu 18.04"
label: Operating system and version
description: The name and version of the operating system you are using.
placeholder: "e.g. Windows 10, macOS High Sierra or Ubuntu 18.04"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, would you mind updating the Ubuntu reference to something newer? Version 18.04 has Go 1.10 (and 20.04 seems to have Go 1.13) as the default repo version 😅

@Jacalz
Copy link
Member

Jacalz commented Feb 18, 2023

You might also want to merge this into master unless you plan to cherry-pick it over :)

@andydotxyz andydotxyz merged commit ad93858 into develop Feb 19, 2023
@andydotxyz andydotxyz deleted the simpler-os-selection branch February 19, 2023 22:21
@andydotxyz
Copy link
Member Author

Thanks, will pick over to master. I did not get round to version name updates, it's just examples :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants