Bugs/default canvas scale #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
reviewed
Feb 23, 2023
|
|
||
| c := container.NewMax(image, bg) | ||
|
|
||
| test.AssertImageMatches(t, "image_size.png", Render(c, theme.LightTheme())) |
There was a problem hiding this comment.
Instead of using this deprecated API why not use the test theme? Or default theme
There was a problem hiding this comment.
I did just follow the pattern of the other tests in this file. I don't really mind switching to a different API, but should we do the same for the rest of the file to keep things consistent?
canvas/image.go
Outdated
| @@ -285,6 +285,24 @@ func (i *Image) calculateMinSize() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (img *Image) scaleSizeForCanvas(width, height int) (fyne.Size, error) { | |||
There was a problem hiding this comment.
Wouldn't this be a good candidate for the new scale package?
There was a problem hiding this comment.
Indeed, good idea!
andydotxyz
requested changes
Feb 24, 2023
Oh, that's a good name. Updated. |
andydotxyz
previously approved these changes
Feb 24, 2023
andydotxyz
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This default image.MinSize() to be calculated with a SCALE=1 when using it with software.Render().
Fixes #2285
Checklist: