Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add building option of fyne tool on termux #3851

Merged
merged 2 commits into from
May 6, 2023
Merged

add building option of fyne tool on termux #3851

merged 2 commits into from
May 6, 2023

Conversation

MatejMagat305
Copy link
Contributor

Description:

this is only small change to provide option build android apk on termux (without pc)

Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

in termux (if you allow, I will create video similar to https://www.youtube.com/watch?v=7aUh39w_-2Q&ab_channel=MatejMagat of course with fyne)

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@coveralls
Copy link

Coverage Status

Coverage: 62.002% (-0.006%) from 62.008% when pulling a7e729e on MatejMagat305:develop into 38a8938 on fyne-io:develop.

@MatejMagat305
Copy link
Contributor Author

well I do not know whether github can test build apk on termux ...

@MatejMagat305 MatejMagat305 changed the title add termux add building option of fyne tool on termux May 3, 2023
@Bluebugs
Copy link
Contributor

Bluebugs commented May 4, 2023

well I do not know whether github can test build apk on termux ...

It can't :-) That's ok, the change is fairly small and I don't think it would affect any other use case. I will approve for now and wait for @andydotxyz to share his opinion too.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks

@andydotxyz andydotxyz merged commit 7de9188 into fyne-io:develop May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants