Only call updateLayout once on the parent. #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
reviewed
May 6, 2023
|
Also, please remember to check the checkmarks in the PR template. |
And don't remove the "tests included" its presence is not optional. If there are no tests, leave it there unchecked so we are fully aware that there are no new tests for this PR. |
Jacalz
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
updateLayout was called for each children that has a min size change instead of one time once all the children have been updated. This lead to some large performance impact on Tree specifically, but all nested container with large number of object would have been impacted.
Checklist: