Guard for nil when closing windows #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks and congratulations on your first Fyne patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As described in: #3870 (comment)
When the autogenerated quit is called from the main menu, if any windows were created but not shown, the program with panic. This is because the viewport would be nil.
This can be fixed with a nil check in
closedFixes #3870
Checklist:
The test that I added fails without my added changes, verified with
go test fyne.io/fyne/v2/internal/driver/glfw -run ClosedBeforeShowhowever on my local machine I have some tests that fail irregardless of my changes (padding/resizing/hoverable) so I am not checking the last box