widget: Add the GridWrap collection widget from @dweymouth #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation was by @dweymouth over at fyne-io/fyne-x#56. This PR includes that work plus selection support and some of the improvements that I have done (see fyne-io/fyne-x#61 and https://github.com/fyne-io/fyne-x/compare/master...Jacalz:gridwrap-selection?expand=1). This was done as a PR directly to Fyne and not fyne-x as the `.super()` call from `widget.BaseWidget` wasn't public and not using it made the selection work bad. All of the changes in this PR compared to the widget in fyne-x can be found here: https://github.com/fyne-io/fyne-x/compare/master...Jacalz:gridwrap-selection?expand=1 Co-authored-by: Drew Weymouth <dweymouth@gmail.com>
|
I don't think we need the "Since: 2.4" line when it is a function attached to a type that has "Since: 2.4" do we? |
|
What you say makes a lot of sense. I thought about that at first but went a bit overboard with it. Will remove some of them |
|
It should be fixed now. Feel free to review when you have the time for it :) |
andydotxyz
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initial implementation was by @dweymouth over at fyne-io/fyne-x#56. This PR includes that work plus selection support and some of the improvements that I have done (see fyne-io/fyne-x#61 and https://github.com/fyne-io/fyne-x/compare/master...Jacalz:gridwrap-selection?expand=1).
This was done as a PR directly to Fyne and not fyne-x as the
.super()call fromwidget.BaseWidgetwasn't public and not using it made the selection work bad. All of the changes in this PR compared to the widget in fyne-x can be found here: https://github.com/fyne-io/fyne-x/compare/master...Jacalz:gridwrap-selection?expand=1Checklist:
Where applicable: