fix: Make gradient resizing refresh and not use cached textures #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
force-pushed
the
fix/expire-gradient-cache-when-size-changes
branch
from
6f1bf29
to
d541a95
Compare
Jacalz
previously requested changes
Mar 4, 2024
|
I would check out how Rectangle (when stroke is on) or the Image canvas types, they already reset the cache when resized. |
adamantike
force-pushed
the
fix/expire-gradient-cache-when-size-changes
branch
from
211c506
to
960fe0e
Compare
adamantike
changed the title
adamantike
force-pushed
the
fix/expire-gradient-cache-when-size-changes
branch
from
960fe0e
to
b5fd9fb
Compare
dweymouth
reviewed
Mar 6, 2024
Avoid using cached textures for gradients, by refreshing the object on resize. Fixes fyne-io#4608.
adamantike
force-pushed
the
fix/expire-gradient-cache-when-size-changes
branch
from
b5fd9fb
to
c0bd61c
Compare
dweymouth
approved these changes
Mar 12, 2024
dweymouth
requested changes
Mar 13, 2024
dweymouth
approved these changes
Mar 19, 2024
|
I forgot to review this one. Sorry about that. Plan to do so tomorrow evening |
Oh whoops, I just merged before I saw this |
|
No problem. I thought you couldn't merge before I had approved so I'm kind of just glad that you relieved me of my duties :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Avoid using cached textures for gradients, by refreshing the object on resize.
Fixes #4608.
Checklist: