Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in RichText when replacing segments #4768

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Fix memory leak in RichText when replacing segments #4768

merged 3 commits into from
Apr 6, 2024

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Apr 5, 2024 •
edited
Loading

Description:

Clean out visualCache entries that are not currently needed on Refresh

Fixes #4723

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

andydotxyz
andydotxyz approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think the clarification on the early escape marks this good.

@andydotxyz andydotxyz merged commit 8c17dda into fyne-io:develop Apr 6, 2024
12 checks passed
dweymouth added a commit to dweymouth/fyne that referenced this pull request Apr 13, 2024
@dweymouth
Pull in mem leak fix from fyne-io/pull/4768
d9a397b
@dweymouth dweymouth deleted the richtext-leak branch June 24, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz left review comments

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dweymouth @andydotxyz @Jacalz