Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close contentFile #4774

Merged
merged 1 commit into from Apr 9, 2024
Merged

fix: close contentFile #4774

merged 1 commit into from Apr 9, 2024

Conversation

testwill
Copy link

@testwill testwill commented Apr 9, 2024 •
edited by andydotxyz

Description:

close contentFile
Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz changed the base branch from master to develop April 9, 2024 08:28
@andydotxyz andydotxyz changed the base branch from develop to master April 9, 2024 08:28
andydotxyz
andydotxyz requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix, but can you please base it on develop branch, as that is where we do our development?
Thanks! I did try to move the commit with GitHub but it didn't work, sorry.

@testwill testwill changed the base branch from master to develop April 9, 2024 08:30
@testwill testwill changed the base branch from develop to master April 9, 2024 08:31
@testwill
Copy link
Author

testwill commented Apr 9, 2024

ok

@testwill
fix: close contentFile
b9e2351 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@testwill testwill changed the base branch from master to develop April 9, 2024 09:05
andydotxyz
andydotxyz approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this

@coveralls
Copy link

Coverage Status

coverage: 64.851% (+0.008%) from 64.843%
when pulling b9e2351 on testwill:clsoe_file
into 8c17dda on fyne-io:develop.

@andydotxyz andydotxyz merged commit 58d0413 into fyne-io:develop Apr 9, 2024
12 checks passed
@andydotxyz
Copy link
Member

Congratulations on your first Fyne PR :)

@testwill testwill deleted the clsoe_file branch April 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@testwill @coveralls @andydotxyz