Fix settings app system theme preview #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With exporting this internally, the settings app can access it and provide a more accurate preview.
…fault” is selected
XDG files should not be included in mobile. For non-Android non-IOS mobile builds (e.g., running tests with `-tags mobile`) the `app_other.go` has to be included, to provide `OpenURL` and `SendNotification`. The whole scheme has clearly evolved over time. Might be useful to separate the different functionalities and get a more clear scheme in the end.
andydotxyz
reviewed
Jun 14, 2024
|
Compiles on Darwin, iOS, Android, WASM - but does not seem to get the preview right on my macOS machine |
You are right, seems I’ve broken something in between. |
|
Found and fixed. |
andydotxyz
requested changes
Jun 14, 2024
| themeNameDark = "dark" | ||
| themeNameLight = "light" | ||
| themeNameSystemLabel = "system default" | ||
| themeNameSystemSettings = "" |
There was a problem hiding this comment.
I was a little confused by the naming - would themeNameSystem be OK? It feels like that matches the other keys, leaving the Label variant just used for label purposes?
andydotxyz
approved these changes
Jun 14, 2024
Jacalz
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The settings app always shows a dark preview for “system default” no matter what the system actually said.
This PR moves the
app.defaultVariant()tointernal/app.DefaultVariant()and thus gives the settings app access to it.Note that someone need to check that this still compiles for all platforms.
Checklist: