Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong theme dependencies #4932

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix wrong theme dependencies #4932

merged 2 commits into from
Jun 14, 2024

Conversation

toaster
Copy link
Member

@toaster toaster commented Jun 13, 2024

Description:

This PR removes dependencies from theme colors which were wrong:

  • The simple color picker’s colors should not be theme dependent.
  • The demo animation should not depend on the theme.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.584% (+0.01%) from 65.57%
when pulling 72d3886 on toaster:bugfix/wrong_theme_dependencies
into 389162b on fyne-io:develop.

@toaster toaster merged commit 22536b4 into fyne-io:develop Jun 14, 2024
12 checks passed
@toaster toaster deleted the bugfix/wrong_theme_dependencies branch June 14, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toaster @coveralls @Jacalz