Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve settings app #4933

Merged
merged 1 commit into from
Jun 14, 2024
Merged

improve settings app #4933

merged 1 commit into from
Jun 14, 2024

Conversation

toaster
Copy link
Member

@toaster toaster commented Jun 13, 2024

Description:

This PR just improves an internal type of the settings app: the color button.
This simplifies future adjustments there.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@toaster
[fyne_settings] remove color from color button and name it properly
e2b49f8 
The color depends on the theme and therefore subject to change.
@toaster toaster requested a review from andydotxyz June 13, 2024 16:57
@coveralls
Copy link

Coverage Status

coverage: 65.57%. remained the same
when pulling e2b49f8 on toaster:refactoring/settings_app
into 389162b on fyne-io:develop.

@toaster toaster merged commit 9458443 into fyne-io:develop Jun 14, 2024
12 checks passed
@toaster toaster deleted the refactoring/settings_app branch June 14, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

@andydotxyz andydotxyz Awaiting requested review from andydotxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toaster @coveralls @Jacalz