fix #706: don't try to adjust insufficient size if it's already at max #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toaster
force-pushed
the
bugfix/706_minsize_adjustment
branch
from
b1cea06
to
6d874e2
Compare
andydotxyz
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This patch is for a very specific case. When an object's size is smaller than its minSize the minSize correction should not resize if the object is already at the maximum (canvas') size.
This case appears with
PopUpwhere the content is larger than the canvas. It would be hidden by making thePopUpcontent scrollable (fixing #675) and would be avoided by addressing #707.Fixes #706
Checklist: