Feature/city input #22
Conversation
I feel skipping this step improves the feel of the app and also fixes the issue where the entry field was showing the full location info instead of just showing the city
home.go
Outdated
| @@ -32,5 +114,6 @@ func (n *nomad) makeHome() fyne.CanvasObject { | |||
| } | |||
| cells = append(cells, n.makeAddCell()) | |||
|
|
|||
| return container.New(&nomadLayout{}, cells...) | |||
| homeContainer = container.New(&nomadLayout{}, cells...) | |||
There was a problem hiding this comment.
It seems the reason for this to become a global is because n.autoCompleteEntry() called from n.makeAddCell() doesn't see it. It should be possible to reorder the code. Pass the container to makeAddCell which would pass it further down to n.autoCompleteEntry(). This would avoid the need for a global.
There was a problem hiding this comment.
I'm having trouble with this, if I declare the homeContainer variable inside makeHome(), I get a pointer error when saving the city. If I make a variable in the nomad struct in main.go, and assign, I get no errors but the city doesn't save correctly.
There was a problem hiding this comment.
If you move the variable declaration into the makeHome then pas s that through makeAddCell into autoCompleteEntry it should work, I think this is what @Bluebugs meant.
Also you could move the declaration to the nomad struct as you say, which may be useful for other code (not sure exactly) it should work as well. The pointer error you mentioned may be because you had two variables of the same name and assigned the wrong one?
location.go
Outdated
| city := widget.NewRichTextFromMarkdown("# " + l.location.name) | ||
| location := widget.NewRichTextFromMarkdown("## " + l.location.country + " · " + l.location.localTime.Format("MST")) | ||
| city := widget.NewRichTextFromMarkdown("# " + strings.ToUpper(l.location.name)) | ||
| location := canvas.NewText(" "+strings.ToUpper(l.location.country)+" · "+l.location.localTime.Format("MST"), color.NRGBA{0xFF, 0xFF, 0xFF, 0xBF}) |
There was a problem hiding this comment.
Is it possible to use a named constante for the color? Ideally something that reflect the meaning of its use.
There was a problem hiding this comment.
I'm unable to declare a constant?
(color.NRGBA literal) (value of type "image/color".NRGBA) is not constant
I created a var but unsure where to place it :)
There was a problem hiding this comment.
Yes, const is very strict for Go but a var at the top level (global is OK here as it's pretending to be a const) make a var( block at the top of the file if one does not exist already.
home.go
Outdated
| entry := NewCompletionEntry([]string{}) | ||
| entry.SetPlaceHolder("Add a Place") | ||
|
|
||
| cardTexts := []string{} |
There was a problem hiding this comment.
Why is cardTexts created here? I am not sure you need to hold a reference to it outside of when there is a change.
There was a problem hiding this comment.
You're right, perhaps a shadow from an earlier solution, I've moved it inside the function
home.go
Outdated
| fmt.Println("Bad submit") | ||
| } else { |
There was a problem hiding this comment.
That should be using fyne.LogError with a custom error.
CompletionEntry.go copied in to repo. Function at ln 136 "newNavigableList" is the only changes to the file
Options showing well
Saving Correctly
